#7783: Port ttnn.upsample to C++ #8237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
reviewed
May 8, 2024
ttnn/cpp/ttnn/operations/others.hpp
Outdated
| inline ttnn::Tensor upsample( | ||
| const ttnn::Tensor& input_tensor, | ||
| //std::variant<float, std::tuple<float, float>, std::tuple<float, float, float>, std::tuple<float, float, float, float>> scale_factor, | ||
| std::variant<int, std::vector<int>> scale_factor, |
There was a problem hiding this comment.
why not change this to use std::variant<std::array<float, 2>, std::array<float, 3>, std::array<float, 4>> and std::visit the helper implementation
There was a problem hiding this comment.
then you avoid the runtime overhead of the vector size checks
There was a problem hiding this comment.
Missed this comment earlier. Makes sense.. I'm gonna update.
cfjchu
reviewed
May 8, 2024
ttnn/cpp/ttnn/operations/others.hpp
Outdated
| TT_THROW("Unsupported scale factor"); | ||
| } | ||
| } | ||
| // DEBUG |
cfjchu
approved these changes
May 8, 2024
xanderchin
force-pushed
the
xan/issue-7783-upsample
branch
from
d786bfc to
1f623e8
Compare
xanderchin
force-pushed
the
xan/issue-7783-upsample
branch
2 times, most recently
from
3348ba6 to
4c189f7
Compare
xanderchin
force-pushed
the
xan/issue-7783-upsample
branch
from
4c189f7 to
36c8585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.