Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3015: Fix std_hw #7708

Merged
merged 1 commit into from
Apr 24, 2024
Merged

#3015: Fix std_hw #7708

merged 1 commit into from
Apr 24, 2024

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Apr 22, 2024 •
edited
Loading

Issues #3015 , #3605

Test results from main branch :

  • There is only decimal level difference between PyTorch result and TT result.
  • Max ATOL value in sweep test is 0.0935.
    • Inserted screenshot and analysis of the result generated- std results.pdf

Fix : Use comp_allclose with atol = 0.1

  • WH_B0 Sweep test : python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/tt_eager/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/wormhole/pytorch_stats_std_hw_test.yaml -o ./result-sweeps : stats_std_hw_sweep_WH_B0.csv

  • GS Sweep test : python tests/tt_eager/python_api_testing/sweep_tests/run_pytorch_test.py -i tests/tt_eager/python_api_testing/sweep_tests/test_configs/ci_sweep_tests_broken/grayskull/pytorch_stats_std_hw_test.yaml -o ./result-sweeps : stats_std_hw_sweep_GS.csv

  • File : tests/tt_eager/python_api_testing/non_working_unit_tests/grayskull/test_stats_std_hw.py

Screenshot 2024-04-22 at 6 53 56 PM
  • All post-commit tests - Link - PASSED
  • Fast Dispatch unit tests - Link - PASSED
  • Slow Dispatch unit tests - Link - PASSED

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/std_fix branch 2 times, most recently from d9150f0 to 2133ffe Compare April 22, 2024 13:28
@VirdhatchaniKN
Copy link
Contributor Author

  • All post-commit tests - Link - PASSED
  • Fast Dispatch unit tests - Link - PASSED
  • Slow Dispatch unit tests - Link - PASSED

@VirdhatchaniKN VirdhatchaniKN merged commit a44e9c9 into main Apr 24, 2024
107 checks passed
@github-actions github-actions bot deleted the virdhatchani/std_fix branch December 18, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-aho tt-aho tt-aho approved these changes

@eyonland eyonland eyonland approved these changes

@arakhmati arakhmati Awaiting requested review from arakhmati

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@ruthreshx ruthreshx Awaiting requested review from ruthreshx

@bharane-ab bharane-ab Awaiting requested review from bharane-ab

@Aswinmcw Aswinmcw Awaiting requested review from Aswinmcw

@KalaivaniMCW KalaivaniMCW Awaiting requested review from KalaivaniMCW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VirdhatchaniKN @eyonland @tt-aho