Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7296: Update ttnn docs #7297

Merged
merged 1 commit into from
Apr 18, 2024
Merged

#7296: Update ttnn docs #7297

merged 1 commit into from
Apr 18, 2024

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Apr 10, 2024

Issue #7296
Updated documentation as required
Screenshot 2024-04-10 at 6 32 07 PM

  • Fast Dispatch unit tests : Link - PASSED
  • Slow Dispatch unit tests : Link - PASSED
  • All post-commit tests : Link - PASSED

Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test.
This looks like we are deviating quite a bit from the pytorch api.

@VirdhatchaniKN
Copy link
Contributor Author

VirdhatchaniKN commented Apr 15, 2024

There is no test. This looks like we are deviating quite a bit from the pytorch api.

Hi @eyonland . The change I have provided is with respect to documentation(as mentioned in Issue) as these 3 ops in particular need their second input to be a tensor and not scalar. Additionally, even if it is scalar, there is no function to convert the scalar into a tensor. Hence the changes.
Regarding test file,
Test File : tests/ttnn/unit_tests/operations/test_math_binary.py
Screenshot 2024-04-15 at 8 35 34 AM

@VirdhatchaniKN VirdhatchaniKN requested a review from eyonland April 15, 2024 03:06
@VirdhatchaniKN
Copy link
Contributor Author

All post-commit tests - Link - PASSED
Fast Dispatch unit tests - Link - PASSED
Slow Dispatch unit tests - Link - PASSED

@VirdhatchaniKN VirdhatchaniKN merged commit 3638f45 into main Apr 18, 2024
107 checks passed
@github-actions github-actions bot deleted the virdhatchani/ttnn_docs branch December 13, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants