Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6123: Add support for backward mvlgamma #6242

Merged
merged 1 commit into from
Mar 18, 2024
Merged

#6123: Add support for backward mvlgamma #6242

merged 1 commit into from
Mar 18, 2024

Conversation

bharane-ab
Copy link
Contributor

  • As the digamma function is only supported for values greater than 1 (>1).
  • The default value of P is set to 4. This is because in the TT framework, we only support tensors with four dimensions.

eyonland
eyonland requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not finding the mvlgamma.py in the forward pass.

tt_eager/tt_dnn/op_library/backward/backward_ops.hpp Outdated Show resolved Hide resolved
@bharane-ab bharane-ab force-pushed the bharane/backward_mvlgamma_dim4 branch from adb2bc3 to f895ddb Compare March 12, 2024 04:59
@bharane-ab bharane-ab requested a review from eyonland March 12, 2024 05:02
@bharane-ab bharane-ab force-pushed the bharane/backward_mvlgamma_dim4 branch 3 times, most recently from 4cfeddb to 195d0fc Compare March 13, 2024 13:59
@bharane-ab bharane-ab force-pushed the bharane/backward_mvlgamma_dim4 branch from 195d0fc to 33facbe Compare March 14, 2024 05:04
@bharane-ab bharane-ab force-pushed the bharane/backward_mvlgamma_dim4 branch from 33facbe to 3c7db11 Compare March 14, 2024 05:10
@bharane-ab bharane-ab force-pushed the bharane/backward_mvlgamma_dim4 branch from 3c7db11 to c705db8 Compare March 18, 2024 09:43
@bharane-ab bharane-ab merged commit b1d3e1b into main Mar 18, 2024
37 checks passed
@bharane-ab bharane-ab mentioned this pull request Mar 18, 2024
Closed
@github-actions github-actions bot deleted the bharane/backward_mvlgamma_dim4 branch November 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyonland eyonland eyonland approved these changes

@arakhmati arakhmati Awaiting requested review from arakhmati

@cfjchu cfjchu Awaiting requested review from cfjchu

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu

@tt-aho tt-aho Awaiting requested review from tt-aho

@mywoodstock mywoodstock Awaiting requested review from mywoodstock

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@ruthreshx ruthreshx Awaiting requested review from ruthreshx

@VirdhatchaniKN VirdhatchaniKN Awaiting requested review from VirdhatchaniKN

@Aswinmcw Aswinmcw Awaiting requested review from Aswinmcw

@KalaivaniMCW KalaivaniMCW Awaiting requested review from KalaivaniMCW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bharane-ab @eyonland