Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Npetrovic/ttnn bin ops #6045

Merged
merged 18 commits into from
Mar 14, 2024
Merged

Npetrovic/ttnn bin ops #6045

merged 18 commits into from
Mar 14, 2024

Conversation

npetrovic-tenstorrent
Copy link
Contributor

@npetrovic-tenstorrent npetrovic-tenstorrent commented Mar 5, 2024 •
edited
Loading

Added sweeps and unit tests for:

  • ldexp
  • logaddexp
  • logaddexp2
  • pow
  • logical and/or/xor

Added BFLOAT8_B compatibility for:

  • exp, exp2, expm1, ldexp, logical operations
    Updated YAML files for:
  • gelu, permute

Added unit tests for failing ops due to low PCC

@npetrovic-tenstorrent npetrovic-tenstorrent self-assigned this Mar 5, 2024
eyonland
eyonland requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you help me understand why we are adding non working unit tests?

@npetrovic-tenstorrent
Copy link
Contributor Author

Would you help me understand why we are adding non working unit tests?

These unit tests are expected the fail with LOW PCC error, but still can be executed, so they can be later assigned to corresponding issues related to these operations. Therefore, someone working on the operation fix regarding PCC would be able to focus on the failing test cases which are here isolated, without necessarily running sweeps for all cases which are even passing.

@boris-drazic boris-drazic merged commit 7d0dbc0 into main Mar 14, 2024
4 checks passed
@TT-billteng TT-billteng mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemanjagrujic nemanjagrujic nemanjagrujic approved these changes

@boris-drazic boris-drazic boris-drazic approved these changes

@arakhmati arakhmati arakhmati approved these changes

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@eyonland eyonland Awaiting requested review from eyonland

@rtawfik01 rtawfik01 Awaiting requested review from rtawfik01 rtawfik01 is a code owner

@acejkov acejkov Awaiting requested review from acejkov

Assignees

@npetrovic-tenstorrent npetrovic-tenstorrent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@npetrovic-tenstorrent @arakhmati @eyonland @boris-drazic @nemanjagrujic