Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5980: Fix a hard-coded bounds check in dprint #6028

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

tt-dma
Copy link
Contributor

@tt-dma tt-dma commented Mar 5, 2024

This was a leftover hard-coded check that only had the grayskull number

@tt-dma tt-dma requested review from pgkeller and ihamer-tt March 5, 2024 17:51
@tt-dma tt-dma force-pushed the dma/5980_dprint_tslice_bounds_fix branch from 939d6db to 9bb8738 Compare March 5, 2024 20:04
@tt-dma
Copy link
Contributor Author

tt-dma commented Mar 5, 2024

Copy link
Contributor

@ihamer-tt ihamer-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@tt-dma tt-dma force-pushed the dma/5980_dprint_tslice_bounds_fix branch from 9bb8738 to 1054db2 Compare March 6, 2024 17:39
@tt-dma tt-dma force-pushed the dma/5980_dprint_tslice_bounds_fix branch from 1054db2 to f68c079 Compare March 6, 2024 21:55
@tt-dma tt-dma merged commit 1056803 into main Mar 6, 2024
4 checks passed
@tt-dma tt-dma deleted the dma/5980_dprint_tslice_bounds_fix branch March 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DPRINT asserts hardcoded L1 address check causing dprint failure on WH_B0
3 participants