#4957: optimizing construct_2d_padded_tensor_list #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtangTT
force-pushed
the
vtangTT/runtime
branch
3 times, most recently
from
5d8f79b to
4840421
Compare
TT-billteng
approved these changes
Feb 28, 2024
tt-nshanker
approved these changes
Feb 28, 2024
...nn/op_library/sliding_window_op_infra/untilize_with_halo_config_generation_and_validation.py
Outdated
Show resolved
Hide resolved
…s from post-commit
…v_to_generate_data_top_left_indices_and_pad_metadata to save loop iterations and memory reallocation
vtangTT
force-pushed
the
vtangTT/runtime
branch
from
4840421 to
a5ccd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will shave off noticeable time off post-commit
Update: Tracy python inflates runtime if many instances of a functions are called, in this case ~150 million of
construct_2d_padded_tensor_listwere called. The real time saved should be around ~60-90 seconds, and the Tracy run should no longer be as inflated