-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convs in Unet on device. Support for 1x1 conv. Fixes. #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-nshanker
requested review from
eyonland,
arakhmati,
cfjchu,
xanderchin,
boris-drazic and
tt-aho
as code owners
February 19, 2024 23:18
tt-nshanker
changed the title
Convs in Unet on device
Convs in Unet on device. Support for 1x1 conv. Fixes.
Feb 19, 2024
tt-nshanker
commented
Feb 19, 2024
tt-nshanker
commented
Feb 19, 2024
boris-drazic
approved these changes
Feb 20, 2024
models/experimental/functional_stable_diffusion/tt/ttnn_functional_basic_transformer_block.py
Show resolved
Hide resolved
models/experimental/functional_stable_diffusion/tt/ttnn_functional_downsample_2d.py
Outdated
Show resolved
Hide resolved
models/experimental/functional_stable_diffusion/tt/ttnn_functional_transformer_2d.py
Outdated
Show resolved
Hide resolved
models/experimental/functional_stable_diffusion/tt/ttnn_functional_upsample_nearest_2d.py
Outdated
Show resolved
Hide resolved
models/experimental/functional_stable_diffusion/tt/ttnn_functional_upsample_nearest_2d.py
Show resolved
Hide resolved
tt-nshanker
commented
Feb 20, 2024
tests/tt_eager/python_api_testing/unit_testing/test_resnet50_untilize_with_halo_and_conv_v2.py
Outdated
Show resolved
Hide resolved
arakhmati
suggested changes
Feb 21, 2024
arakhmati
approved these changes
Feb 21, 2024
tt-nshanker
force-pushed
the
nshanker/sd_unet_rebased_to_main
branch
3 times, most recently
from
February 21, 2024 20:23
43b77ee
to
a7c1831
Compare
mywoodstock
approved these changes
Feb 21, 2024
mywoodstock
reviewed
Feb 21, 2024
tests/ttnn/integration_tests/stable_diffusion/test_unet_2d_condition_model.py
Outdated
Show resolved
Hide resolved
arakhmati
suggested changes
Feb 22, 2024
arakhmati
approved these changes
Feb 22, 2024
tt-nshanker
force-pushed
the
nshanker/sd_unet_rebased_to_main
branch
from
February 22, 2024 20:36
7b7feaf
to
1194863
Compare
tt-nshanker
force-pushed
the
nshanker/sd_unet_rebased_to_main
branch
from
February 22, 2024 20:40
1194863
to
a273b8e
Compare
tt-nshanker
temporarily deployed
to
production
February 22, 2024 21:07 — with
GitHub Actions
Inactive
tt-nshanker
temporarily deployed
to
production
February 22, 2024 21:07 — with
GitHub Actions
Inactive
tt-nshanker
temporarily deployed
to
production
February 22, 2024 21:07 — with
GitHub Actions
Inactive
tt-nshanker
temporarily deployed
to
production
February 22, 2024 21:07 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://github.com/tenstorrent-metal/tt-metal/actions/runs/7997467579
Running failed tests again after fix: https://github.com/tenstorrent-metal/tt-metal/actions/runs/8000487426
https://github.com/tenstorrent-metal/tt-metal/actions/runs/8000494864
Fixed remaining CI failures locally.