Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4686: add infra for sharing global struct among ops #5456

Merged
merged 7 commits into from
Feb 26, 2024
Merged

#4686: add infra for sharing global struct among ops #5456

merged 7 commits into from
Feb 26, 2024

Conversation

yugaoTT
Copy link
Contributor

@yugaoTT yugaoTT commented Feb 16, 2024

  1. add sharing global struct for fp32, math_approx, packer_l1_acc, fidelity
  2. test on operation primary matmul

@yugaoTT yugaoTT self-assigned this Feb 16, 2024
@TT-BrianLiu
Copy link
Contributor

Should we be using ComputeKernelConfig and DeviceComputeKernelConfig instead of just KernelConfig? These configs specifically apply to compute kernels. Or is this too verbose?

@yugaoTT
Copy link
Contributor Author

yugaoTT commented Feb 16, 2024

yes I like DeviceComputeKernelConfig better as well.

@yugaoTT yugaoTT requested a review from rtawfik01 February 21, 2024 01:41
@yugaoTT yugaoTT force-pushed the yugao/fp32_ops branch 2 times, most recently from ca2b91d to 297b5be Compare February 21, 2024 01:59
@yugaoTT yugaoTT merged commit 48fe3e5 into main Feb 26, 2024
4 checks passed
@yugaoTT yugaoTT deleted the yugao/fp32_ops branch March 11, 2024 14:43
@yugaoTT yugaoTT restored the yugao/fp32_ops branch March 11, 2024 14:43
@yugaoTT yugaoTT deleted the yugao/fp32_ops branch March 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtawfik01 rtawfik01 rtawfik01 approved these changes

@boris-drazic boris-drazic boris-drazic approved these changes

@arakhmati arakhmati arakhmati approved these changes

@mywoodstock mywoodstock mywoodstock approved these changes

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@eyonland eyonland Awaiting requested review from eyonland

@cfjchu cfjchu Awaiting requested review from cfjchu

@xanderchin xanderchin Awaiting requested review from xanderchin

Assignees

@yugaoTT yugaoTT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yugaoTT @TT-BrianLiu @mywoodstock @arakhmati @boris-drazic @rtawfik01