Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocator Alignment Uplift and OP side adaption. #16950

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

Allocator Alignment Uplift and OP side adaption. #16950

wants to merge 59 commits into from

Conversation

llongTT
Copy link
Contributor

@llongTT llongTT commented Jan 21, 2025

Ticket

Link to Github Issue

Problem description

Provide context for the problem.

What's changed

Describe the approach used to solve the problem.
Summarize the changes made and its impact.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

abhullar-tt and others added 30 commits December 4, 2024 00:40
@abhullar-tt
#13609: Uplift dram and l1 allocators to use dram/l1 specific alignment
27ff243
@abhullar-tt
#13609: Update memcpy to device to handle 16B aligned writes
21e4632
@sjameelTT @abhullar-tt
#12549: Fix BH unaligned read issue for tiled interleaved transpose HC
f48416c
@llongTT
Merge branch 'main' into abhullar/diff-aligns
92d0d5f
@llongTT
#13609: remove the change to genfiles.cpp/hpp
479f4da
@llongTT
#13609: also remove the deprecated call of jit_build_genfiles_bank_to…
1c4ea2d 
…_noc_coord_descriptor
@llongTT
#13609: fix the build failure due to allocator_alignment change
7d8ae9a
@llongTT
Merge branch 'main' into abhullar/diff-aligns
86af491
@llongTT
Merge branch 'main' into abhullar/diff-aligns
fff8bbb
@llongTT
Merge branch 'main' into abhullar/diff-aligns
9590f84
@llongTT
#13609: enforce the alignment to the max of input/output to allow noc…
45be757 
… asyn read
@llongTT
#13609: fix the failed test_sharded tests, using keep_l1_aligned flag
c9cbdff
@llongTT
#13609: take care of sharded padding failure due to DRAM/L1 alignmen…
353945b 
…t issue
@llongTT
#13609: stick to the usage of keep_l1_aligned = True for now
5e0bdda
@llongTT
#13609: switch to i2s/s2i call explicitly to keep l1 aligned
628e010
@llongTT
Merge branch 'main' into abhullar/diff-aligns
740938e
@llongTT
Merge branch 'main' into abhullar/diff-aligns
53c9f09
@llongTT
Merge branch 'main' into abhullar/diff-aligns
49aef72
@llongTT
Merge branch 'main' into abhullar/diff-aligns
d8a7c8d
@abhullar-tt
Add allocator api to get alignment based on all buffer types
0174c05
@llongTT
Merge branch 'main' into abhullar/diff-aligns
6f16c44
@llongTT
#13609: Temporarily skip the failed tests to see if more tests fail
7c46541
@llongTT
#13609: skip more tests
de04fc0
@llongTT
#13609: Update to address the group norm unit test issue
939caa5
@llongTT
#13609: enable group norm tests
af1451f
@llongTT
#13609: fix of test fold issue, working on GS now
4b1ab24
@llongTT
fix the segmentation fault due to the hugepage address alignment chec…
774dc43 
…k failure
@llongTT
#13609: enable test_permute_5d_blocked as the memory issue has been f…
fead9bc 
…ixed
@llongTT
#13609: explicitely pack l1 for group norm unit test of test_group_no…
ffbf4a4 
…rm_with_block_sharded_v2_8x8_grid
@llongTT
#13609: address some review comment, regarding comments and variable …
45ed294 
…name for l1 alignment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@bbradelTT bbradelTT Awaiting requested review from bbradelTT bbradelTT is a code owner

@yugaoTT yugaoTT Awaiting requested review from yugaoTT yugaoTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@asandhupatlaTT asandhupatlaTT Awaiting requested review from asandhupatlaTT asandhupatlaTT is a code owner

@ntarafdar ntarafdar Awaiting requested review from ntarafdar ntarafdar is a code owner

@sjameelTT sjameelTT Awaiting requested review from sjameelTT sjameelTT is a code owner

@jaykru-tt jaykru-tt Awaiting requested review from jaykru-tt jaykru-tt is a code owner

@yugi957 yugi957 Awaiting requested review from yugi957 yugi957 is a code owner

@jvegaTT jvegaTT Awaiting requested review from jvegaTT jvegaTT is a code owner

@nardoTT nardoTT Awaiting requested review from nardoTT nardoTT is a code owner

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@omilyutin-tt omilyutin-tt Awaiting requested review from omilyutin-tt omilyutin-tt is a code owner

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@pgkeller pgkeller Awaiting requested review from pgkeller pgkeller is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

@davorchap davorchap Awaiting requested review from davorchap davorchap is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@llongTT @abhullar-tt @sjameelTT