Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port all experimental ops to compute_output_specs #16595

Merged
merged 4 commits into from
Jan 12, 2025
Merged

Port all experimental ops to compute_output_specs #16595

merged 4 commits into from
Jan 12, 2025

Conversation

sminakov-tt
Copy link
Contributor

@sminakov-tt sminakov-tt commented Jan 10, 2025 •
edited
Loading

Ticket

Problem description

We're continuing to port all OPs from compute_output_shapes to compute_output_specs

What's changed

Ported all experimental ops to compute_output_specs

Checklist

SeanNijjar
SeanNijjar approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@SeanNijjar SeanNijjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you please add t3k nightly to the list?

@SeanNijjar
Copy link
Contributor

SeanNijjar commented Jan 10, 2025 •
edited
Loading

Also I think the failures in your t3k frequent are okay - as in not a something due to your changes. There seems to be something flaky with pcie_mesh_device used in some of these tests (test_reduce_scatter_post_commit.py::test_width_sharded_reduce_scatter_post_commit_4chip) on certain T3K machines

@sminakov-tt
Copy link
Contributor Author

@SeanNijjar Added T3K Nightly, rerun the tests - everything passes

@sminakov-tt sminakov-tt merged commit 1a7e545 into main Jan 12, 2025
220 checks passed
@sminakov-tt sminakov-tt deleted the sminakov/exp-ops-specs branch January 12, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@bbradelTT bbradelTT bbradelTT approved these changes

@SeanNijjar SeanNijjar SeanNijjar approved these changes

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@yugaoTT yugaoTT Awaiting requested review from yugaoTT yugaoTT is a code owner

@asandhupatlaTT asandhupatlaTT Awaiting requested review from asandhupatlaTT asandhupatlaTT is a code owner

@jvegaTT jvegaTT Awaiting requested review from jvegaTT jvegaTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sminakov-tt @SeanNijjar @bbradelTT @ayerofieiev-tt