Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#16366: Changed default kernal_config_val for 32bit matmul #16567

Merged
merged 3 commits into from
Jan 10, 2025
Merged

#16366: Changed default kernal_config_val for 32bit matmul #16567

merged 3 commits into from
Jan 10, 2025

Conversation

vsureshTT
Copy link
Contributor

@vsureshTT vsureshTT commented Jan 9, 2025 •
edited
Loading

Ticket

Link to Github Issue
#16366

Problem description

FP32 PCC not accurate enough for a matmul with default kernel config

What's changed

Enabled FP32 and disabled L1ACC for FP32

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@dgolubovicTT dgolubovicTT mentioned this pull request Jan 10, 2025
Open
@vsureshTT vsureshTT merged commit 652490d into main Jan 10, 2025
263 checks passed
@vsureshTT vsureshTT deleted the vsureshTT-patch-1 branch January 10, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbradelTT bbradelTT bbradelTT approved these changes

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@rfurko-tt rfurko-tt Awaiting requested review from rfurko-tt rfurko-tt is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

@yugaoTT yugaoTT Awaiting requested review from yugaoTT yugaoTT is a code owner

@asandhupatlaTT asandhupatlaTT Awaiting requested review from asandhupatlaTT asandhupatlaTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsureshTT @bbradelTT