Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Used github team for conv files #16563

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Conversation

sankarmanoj-tt
Copy link
Contributor

What's changed

Updated CODEOWNERS to use @tenstorrent/metalium-developers-convolutions for conv related files.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@mywoodstock mywoodstock marked this pull request as ready for review January 9, 2025 22:30
@mywoodstock mywoodstock requested a review from a team as a code owner January 9, 2025 22:30
CODEOWNERS Outdated
ttnn/cpp/ttnn/operations/pool/ @mywoodstock @shwetankTT @sankarmanoj-tt @pavlejosipovic
ttnn/cpp/ttnn/operations/conv/ @mywoodstock @shwetankTT @sankarmanoj-tt @pavlejosipovic
ttnn/cpp/ttnn/operations/sliding_window/ @mywoodstock @sankarmanoj-tt @pavlejosipovic
ttnn/cpp/ttnn/operations/pool/ @@tenstorrent/metalium-developers-convolutions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
I've fixed it.

@sankarmanoj-tt
Copy link
Contributor Author

image

Looks like the team is not set up correctly.

@tt-rkim
Copy link
Collaborator

tt-rkim commented Jan 10, 2025

Changed permissions

Please check again

@sankarmanoj-tt sankarmanoj-tt force-pushed the smanoj/update_conv_codeowners branch from 3c137cb to f98d543 Compare January 11, 2025 15:13
@sankarmanoj-tt sankarmanoj-tt merged commit 195e74a into main Jan 11, 2025
9 checks passed
@sankarmanoj-tt sankarmanoj-tt deleted the smanoj/update_conv_codeowners branch January 11, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants