Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Binary Sfpu ops to binary_ng with activations #16523

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Jan 8, 2025

Ticket

Link to Github Issue #16144

Problem description

Binary_ng ops support only bfloat16 datatype
bitwise ops, rsub, pow are not present in binary_ng

What's changed

Added float32 support for binary_ng ops
Added bitwise ops and add_int32 op
Added rsub and pow to binary_ng

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/ngfp32_activ branch from bb2f9e5 to d02a04a Compare January 9, 2025 19:41
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/ngfp32_activ branch 2 times, most recently from 78404f6 to 1fc8c3f Compare January 10, 2025 14:25
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/ngfp32_activ branch from 1fc8c3f to 58500f2 Compare January 11, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants