Fix ttnn.from_torch for 0D/1D tensors with tile layout #16484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sminakov-tt
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT,
llongTT and
nardoTT
as code owners
bbradelTT
approved these changes
Jan 8, 2025
6 tasks
ayerofieiev-tt
pushed a commit
that referenced
this pull request
Jan 9, 2025
### Ticket ### Problem description There is a double move occurring inside invoke_composite / launch_op. The issue is caused by passing a mutable lambda, which changes the argument into launch_op, which in turn calls the lambda multiple times. This change is a prerequisite for #16484 ### What's changed Remove `mutable` modifier for the passed lambda, removed incorrect usages of `std::forward`. ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12685459880) - [x] [T3K frequent CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12685464588) - [x] [T3K unit tests CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12687593651) - [x] [Model regression CI testing passes](https://github.com/tenstorrent/tt-metal/actions/runs/12685476479) - [x] [Device performance regression CI testing passes](https://github.com/tenstorrent/tt-metal/actions/runs/12685472338) - [x] New/Existing tests provide coverage for changes
ayerofieiev-tt
approved these changes
Jan 10, 2025
4 tasks
sminakov-tt
added a commit
that referenced
this pull request
Jan 11, 2025
### Ticket ### Problem description Nightly stable diffusion tests are currently failing, after #16484 ### What's changed Fixed calculation of `output_tensor_end` in one of the branches of layout conversion ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/12718154798) - [x] [Device performance regression CI testing passes](https://github.com/tenstorrent/tt-metal/actions/runs/12718161215) - [x] [Nightly model and ttnn tests](https://github.com/tenstorrent/tt-metal/actions/runs/12718140006) - [x] New/Existing tests provide coverage for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Problem description
Part 3 of the original PR for
ttnn.from_torchsupport for 0D/1D tensors with tile layout which got reverted previouslyWhat's changed
Variety of Shape fixes throughout the codebase
Checklist