Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16415: fix moreh_adam #16420

Merged
merged 1 commit into from
Jan 22, 2025
Merged

#16415: fix moreh_adam #16420

merged 1 commit into from
Jan 22, 2025

Conversation

hschoi4448
Copy link
Contributor

@hschoi4448 hschoi4448 commented Jan 3, 2025

Ticket

#16415

Problem description

I recently ran test_moreh_adam.py and discovered that the test is failing. The reason it hasn't been detected until now is because the failure is due to TT_ASSERT, which hasn't been caught by GitHub Actions so far.

What's changed

  1. fix test_moreh_adam.py
  • I fixed an issue where an unnecessary output tensor was being passed as an input when amsgrad is set to false.
  1. fix moreh_adam create_output_tensors
  • I corrected a missing nullopt that should have been included to maintain a consistent number of outputs.
  1. fix override_runtime_arguments
  • I fixed an issue where an optional tensor was accessed without checking whether it contained a value, which caused an error.

Checklist

@hschoi4448 hschoi4448 added the bug Something isn't working label Jan 3, 2025
@hschoi4448 hschoi4448 marked this pull request as ready for review January 3, 2025 07:14
@hschoi4448
Copy link
Contributor Author

Currently, checklist is not check. But I will run all the tests before merge.

@hschoi4448 hschoi4448 force-pushed the hyungsuk/fix_moreh_adam branch 2 times, most recently from f3e7f96 to 27b0966 Compare January 6, 2025 00:33
@hschoi4448 hschoi4448 added the moreh moreh contribution label Jan 8, 2025
@hschoi4448 hschoi4448 force-pushed the hyungsuk/fix_moreh_adam branch 3 times, most recently from 732e481 to efd7356 Compare January 14, 2025 01:38
@hschoi4448 hschoi4448 force-pushed the hyungsuk/fix_moreh_adam branch 3 times, most recently from 5d35c32 to 375dd4a Compare January 21, 2025 07:26
@hschoi4448 hschoi4448 force-pushed the hyungsuk/fix_moreh_adam branch from 375dd4a to 671fdc0 Compare January 22, 2025 01:52
@hschoi4448 hschoi4448 merged commit fdc31b3 into main Jan 22, 2025
16 of 18 checks passed
@hschoi4448 hschoi4448 deleted the hyungsuk/fix_moreh_adam branch January 22, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working moreh moreh contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants