Remove old fd init code path #16321
Open
Remove old fd init code path #16321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-dma
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
omilyutin-tt
requested changes
Dec 26, 2024
| @@ -3980,35 +1867,6 @@ std::vector<CoreCoord> Device::get_optimal_dram_bank_to_logical_worker_assignmen | |||
| return this->optimal_dram_bank_to_logical_worker_assignment_; | |||
| } | |||
|
|
|||
| HalProgrammableCoreType Device::get_programmable_core_type(CoreCoord virtual_core) const { | |||
There was a problem hiding this comment.
This PR undoes (some of? all?) changes @ayerofieiev-tt made in #16259 -- is this intentional, or bad rebase?
There was a problem hiding this comment.
Bad rebase I think, let me check on this
arikTT
reviewed
Dec 26, 2024
| } | ||
|
|
||
| void Device::begin_trace(const uint8_t cq_id, const uint32_t tid) { | ||
| ZoneScoped; | ||
| TracyTTMetalBeginTrace(this->id(), tid); | ||
| TT_FATAL(!this->hw_command_queues_[cq_id]->tid.has_value(), "CQ {} is already being used for tracing tid {}", (uint32_t)cq_id, tid); | ||
| this->mark_allocations_safe(); | ||
| this->MarkAllocationsSafe(); |
There was a problem hiding this comment.
why are we changing casing? Even for camel case, first m should be lower case
There was a problem hiding this comment.
Bad rebase I think, will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New FD init has landed and seems stable, this PR removes the old FD init.
CI: https://github.com/tenstorrent/tt-metal/actions/runs/12489907171, https://github.com/tenstorrent/tt-metal/actions/runs/12495980066 (same failures as main)