#0: Typo fix in TT distributed tech report #16308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omilyutin-tt
commented
Dec 24, 2024
| @@ -1016,18 +1016,18 @@ Below, we include snippets from both the TT-Mesh and TT-Metal examples to illust | |||
| MeshConfig mesh_config_0 = MeshConfig{.shape = virtual_mesh_shape, .offset = {0, 0}, .type=mesh_type}; | |||
| MeshConfig mesh_config_1 = MeshConfig{.shape = virtual_mesh_shape, .offset = {0, 4}, .type=mesh_type}; | |||
|
|
|||
| DeviceHandle virtual_mesh_0 = CreateMeshDevice(mesh_config_0, 2 /* num_cqs */, DEFAULT_L1_SMALL_SIZE, DEFAULT_TRACE_REGION_SIZE, 1 /* num_command_queues */); | |||
| DeviceHandle virtual_mesh_1 = CreateMeshDevice(mesh_config_1, 2 /* num_cqs */, DEFAULT_L1_SMALL_SIZE, DEFAULT_TRACE_REGION_SIZE, 1 /* num_command_queues */); | |||
| DeviceHandle virtual_mesh_0 = CreateMeshDevice(mesh_config_0, DEFAULT_L1_SMALL_SIZE, DEFAULT_TRACE_REGION_SIZE, 1 /* num_command_queues */); | |||
There was a problem hiding this comment.
num_cqs and num_command_queues were repeated. This version also aligns with the existing mesh device impl.
omilyutin-tt
commented
Dec 24, 2024
| @@ -1070,7 +1070,7 @@ DeviceLocalLayoutConfig per_device_buffer_config { | |||
| ShardedBufferConfig distributed_buffer_config_virtual_mesh_0 { | |||
| .mesh_device = virtual_mesh_0; | |||
| .buffer_type = BufferType::DRAM, | |||
| .global_tensor_shape = global_tensor_shape, | |||
| .global_buffer_shape = global_buffer_shape, | |||
There was a problem hiding this comment.
As per the declaration earlier in the document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/A