Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile issue for earlier c++ versions #16291

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

SeanNijjar
Copy link
Contributor

@SeanNijjar SeanNijjar commented Dec 23, 2024

Ticket

Link to Github Issue

Problem description

MLIR hit a compile issue when uplifting to latest metal.

What's changed

Rollback some c++20 feature usage back to c++17. Confirmed with @sdjordjevicTT that this resolves there issue. Otherwise without this fix MLIR uplift is blocked.

Checklist

@SeanNijjar SeanNijjar requested a review from cfjchu as a code owner December 23, 2024 18:25
@SeanNijjar SeanNijjar force-pushed the snijjar/compile-fix-mlir-uplift branch from 54186d4 to cd72031 Compare December 23, 2024 20:19
@SeanNijjar SeanNijjar merged commit 47a5253 into main Dec 24, 2024
138 of 184 checks passed
@SeanNijjar SeanNijjar deleted the snijjar/compile-fix-mlir-uplift branch December 24, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants