Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Fix get_dispatch_core_config in conftest.py to not modify the device_params to not affect subsequent tests #16290

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

tt-aho
Copy link
Contributor

@tt-aho tt-aho commented Dec 23, 2024

Changed to a new function get_updated_device_params that returns a new updated copy of device_params instead

Ticket

Link to Github Issue

Problem description

get_dispatch_core_config was modifying the device_params dict in place by popping elements out of the dict for dispatch core axis. If we run 2 tests parametrized on core axis being col for example, the first test would see this set to col and pop it, but then the second test would see this set to the default (row), resulting in incorrect behaviour.

What's changed

Changed get_dispatch_core_config to get_updated_device_params which does not modify the original device_params dict, and instead returns a new copy with the updated parameters.

Checklist

…ice_params to not affect subsequent tests

Changed to a new function get_updated_device_params that returns a new updated copy of device_params instead
@tt-aho tt-aho requested review from cfjchu, SeanNijjar and a team as code owners December 23, 2024 18:03
@tt-aho tt-aho merged commit c0c1bb6 into main Dec 26, 2024
185 checks passed
@tt-aho tt-aho deleted the aho/device_params branch December 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants