-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16134: add test cases for pre-allocated CreateBuffer / ttnn::event_query #16135
Open
ilkoo-lee
wants to merge
2
commits into
main
Choose a base branch
from
ilkoo/16134_add_test_case_preallocated_create_buffer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#16134: add test cases for pre-allocated CreateBuffer / ttnn::event_query #16135
ilkoo-lee
wants to merge
2
commits into
main
from
ilkoo/16134_add_test_case_preallocated_create_buffer
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilkoo-lee
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
December 18, 2024 14:30
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 23, 2024 09:41
99fbfe1
to
06713f0
Compare
ilkoo-lee
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na and
bbradelTT
as code owners
December 23, 2024 09:41
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 23, 2024 09:42
06713f0
to
964b66d
Compare
@ilkoo-lee is the addition of the pybind submodule intentional for this pr? Looks like it might have been a bad rebase since this was removed on main |
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 24, 2024 06:37
964b66d
to
fdbf6f6
Compare
No, it was not intentional. I have fixed it |
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 24, 2024 06:40
fdbf6f6
to
f3adb9f
Compare
ilkoo-lee
changed the title
#16134: add test case for pre-allocated CreateBuffer
#16134: add test cases for pre-allocated CreateBuffer / ttnn::event_query
Dec 24, 2024
tt-aho
reviewed
Dec 24, 2024
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 24, 2024 08:10
f3adb9f
to
eea4b3d
Compare
ilkoo-lee
force-pushed
the
ilkoo/16134_add_test_case_preallocated_create_buffer
branch
from
December 24, 2024 08:13
eea4b3d
to
6c891fb
Compare
tt-aho
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#16134
Problem description
There are no test cases for the following APIs
What's changed
Add proper test cases
Checklist