Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16134: add test cases for pre-allocated CreateBuffer / ttnn::event_query #16135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ilkoo-lee
Copy link
Contributor

@ilkoo-lee ilkoo-lee commented Dec 18, 2024

Ticket

#16134

Problem description

There are no test cases for the following APIs

  1. CreateBuffer : Creates a buffer over a preallocated addres:
std::shared_ptr<Buffer> CreateBuffer(const InterleavedBufferConfig& config, DeviceAddr address);
  1. ttnn::event_query

What's changed

Add proper test cases

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@ilkoo-lee ilkoo-lee added the moreh moreh contribution label Dec 19, 2024
@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from 99fbfe1 to 06713f0 Compare December 23, 2024 09:41
@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from 06713f0 to 964b66d Compare December 23, 2024 09:42
@tt-aho
Copy link
Contributor

tt-aho commented Dec 23, 2024

@ilkoo-lee is the addition of the pybind submodule intentional for this pr? Looks like it might have been a bad rebase since this was removed on main

@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from 964b66d to fdbf6f6 Compare December 24, 2024 06:37
@ilkoo-lee
Copy link
Contributor Author

ilkoo-lee commented Dec 24, 2024

@ilkoo-lee is the addition of the pybind submodule intentional for this pr? Looks like it might have been a bad rebase since this was removed on main

No, it was not intentional. I have fixed it

@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from fdbf6f6 to f3adb9f Compare December 24, 2024 06:40
@ilkoo-lee ilkoo-lee changed the title #16134: add test case for pre-allocated CreateBuffer #16134: add test cases for pre-allocated CreateBuffer / ttnn::event_query Dec 24, 2024
@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from f3adb9f to eea4b3d Compare December 24, 2024 08:10
@ilkoo-lee ilkoo-lee force-pushed the ilkoo/16134_add_test_case_preallocated_create_buffer branch from eea4b3d to 6c891fb Compare December 24, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moreh moreh contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants