Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create standalone CCL and CCL experimental python module bindings #16064

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SeanNijjar
Copy link
Contributor

@SeanNijjar SeanNijjar commented Dec 16, 2024

Ticket

No Issue - just light reorg

Checklist

Comment on lines +7 to +8
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the fwd include to further lighten the header


#pragma once

#include "ttnn/operations/ccl/all_gather/all_gather_pybind.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please split to .hpp and .cpp

Copy link
Member

@ayerofieiev-tt ayerofieiev-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so you don't have to wait once the feedback is addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants