Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#0: Re-order reshape and device upload in test_tilize_zero_padding_channels_last.cpp #15913

Merged
merged 1 commit into from
Dec 11, 2024
Merged

#0: Re-order reshape and device upload in test_tilize_zero_padding_channels_last.cpp #15913

merged 1 commit into from
Dec 11, 2024

Conversation

omilyutin-tt
Copy link
Contributor

@omilyutin-tt omilyutin-tt commented Dec 11, 2024 •
edited
Loading

Problem description

PR possibly introduced a failure in the test.

What's changed

Re-shape now happens on the host, before uploading a tensor on device.

Checklist

  • Post commit CI passes
  • Manual test on a grayskull machine - reproduced the issue and confirmed the fix resolves it.

@omilyutin-tt omilyutin-tt marked this pull request as ready for review December 11, 2024 16:57
@omilyutin-tt omilyutin-tt merged commit fc04d9d into main Dec 11, 2024
124 of 126 checks passed
@omilyutin-tt omilyutin-tt deleted the omilyutin/fix-numpy branch December 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-asaigal tt-asaigal tt-asaigal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omilyutin-tt @tt-asaigal