Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Add gmock to tt_metal test infra #15890

Merged
merged 2 commits into from
Dec 11, 2024
Merged

#0: Add gmock to tt_metal test infra #15890

merged 2 commits into from
Dec 11, 2024

Conversation

omilyutin-tt
Copy link
Contributor

@omilyutin-tt omilyutin-tt commented Dec 11, 2024

Added sample uses in tests/ttnn/unit_tests/gtests/tensor/test_create_tensor_multi_device.cpp and tt-train/tests/core/distributed_test.cpp as a demo and confirm all is working.

Checklist

[X] Post commit CI passes

@@ -7,6 +7,7 @@ target_link_libraries(
pthread
gtest
gtest_main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
gtest_main
gmock_main

Copy link
Contributor

@afuller-TT afuller-TT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes and yes!! \o/
But we should switch to gmock_main now that we're using gmock.

@omilyutin-tt omilyutin-tt merged commit f37ad77 into main Dec 11, 2024
119 checks passed
@omilyutin-tt omilyutin-tt deleted the omilyutin/gmock branch December 11, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants