#15863: Implementing the view operation #15865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvegaTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
yan-zaretskiy,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957 and
llongTT
as code owners
ntarafdar
approved these changes
Dec 10, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bbradelTT
reviewed
Dec 10, 2024
bbradelTT
reviewed
Dec 10, 2024
bbradelTT
reviewed
Dec 10, 2024
…/tt-metal into jvega/view_op_implementation
…/tt-metal into jvega/view_op_implementation
bbradelTT
approved these changes
Dec 10, 2024
ayerofieiev-tt
approved these changes
Dec 10, 2024
| @pytest.mark.parametrize( | ||
| "input_shape, output_shape, layout", | ||
| [ | ||
| ((1, 15), (15,), ttnn.ROW_MAJOR_LAYOUT), # RM_last dimension matches, 1D output |
There was a problem hiding this comment.
could add test which demonstrates that it will throw if I pass wrong dimensions?
There was a problem hiding this comment.
That is done in test_invalid_cases
There was a problem hiding this comment.
I just saw it! thanks.
dmakoviichuk-tt
approved these changes
Dec 10, 2024
|
I am waiting for post commit to run again before merging, I'm a little paranoid with the simple shape change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#15863
Problem description
Models team has asked for a 0-cost view op which asserts out if a 0 cost view is not possible for that request
What's changed
Implemented 0-cost view that provides the proper input validation and then calls the perform_view function in reshape
Checklist