#15075: Adding assert for completely invalid reshapes #15846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enstorrent/tt-metal into atulk/incorrect-reshape-assert
jvegaTT
requested review from
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957 and
llongTT
as code owners
ntarafdar
reviewed
Dec 9, 2024
| @@ -52,36 +52,6 @@ ttnn::Tensor convert_tile_to_rm( | |||
| (tensor.get_dtype() == DataType::BFLOAT8_B) ? ttnn::typecast(new_tensor, tensor.get_dtype()) : new_tensor; | |||
| return new_tensor; | |||
| } | |||
| ttnn::Tensor host_reshape(const ttnn::Tensor& tensor, const ttnn::Shape& shape) { | |||
There was a problem hiding this comment.
So happy to see this removed
There was a problem hiding this comment.
RIP - it won't be missed
|
Lets go , reshape is pretty much perfect |
ntarafdar
approved these changes
Dec 9, 2024
|
once this passes pipelines lets get this in :) |
yugi957
approved these changes
Dec 9, 2024
jvegaTT
changed the title
rdjogoTT
pushed a commit
that referenced
this pull request
Dec 10, 2024
### Ticket #15075 ### Problem description We add a validation check for reshape when the volumes do not match as the embedding issue preventing this is now solved We deleted the reshape host fallback code that is no longer needed ### Checklist - [x] Post commit CI passes https://github.com/tenstorrent/tt-metal/actions/runs/12190290996 - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes --------- Co-authored-by: yugi957 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#15075
Problem description
We add a validation check for reshape when the volumes do not match as the embedding issue preventing this is now solved
We deleted the reshape host fallback code that is no longer needed
Checklist