Add reflection for std::unordered_map to support hashing global circular buffers #15797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
cfjchu,
TT-BrianLiu,
patrickroberts,
yan-zaretskiy,
eyonland,
sminakov-tt,
abhullar-tt,
pgkeller,
aliuTT,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
force-pushed
the
aho/hash-global-cb
branch
from
ee9faa4 to
a5e4724
Compare
tt-aho
removed request for
abhullar-tt,
TT-BrianLiu,
cfjchu,
pgkeller,
tt-asaigal,
ubcheema,
aliuTT and
tt-dma
tt-aho
changed the title
tt-aho
force-pushed
the
aho/hash-global-cb
branch
from
a5e4724 to
7210be5
Compare
ayerofieiev-tt
approved these changes
Dec 9, 2024
sminakov-tt
reviewed
Dec 9, 2024
tt_metal/tt_stl/reflection.hpp
Outdated
| // Combine using xor so that the hash is order invariant | ||
| // Alternative could be to sort the keys before hashing | ||
| for (const auto& [key, value] : object) { | ||
| hash ^= hash_objects(seed, key, value); |
There was a problem hiding this comment.
I would be a bit worried by this, possibly introduces some extra hash collisions. I would prefer to sort them instead
There was a problem hiding this comment.
That makes sense. I will change to sort instead
There was a problem hiding this comment.
@sminakov-tt I've updated to sort first then hash the same way as std::map. Let me know if this looks okay now.
sminakov-tt
approved these changes
Dec 9, 2024
tt-aho
force-pushed
the
aho/hash-global-cb
branch
from
7210be5 to
d4109d1
Compare
tt-asaigal
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Need to support hashing the GlobalCircularBuffer object in order to be consumed by ops, which has an unordered_map.
What's changed
Add hashing support for std::map and std::unordered_map.
Checklist