#15602: ttnn-padding padding size enhancement. #15758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70eda8b.
…ent/tt-metal into llong/ttnn-padding-length-issue
…ent/tt-metal into llong/ttnn-padding-length-issue
…ent/tt-metal into llong/ttnn-padding-length-issue
llongTT
requested review from
ntarafdar,
sjameelTT and
jaykru-tt
as code owners
|
Amazing, can we add a unit test for this case? |
ntarafdar
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#15602
Link to Github Issue
Problem description
When use padding size that's not multiples of 16, the result is erroneous
What's changed
Re-design the kernel to allow arbitrary front pad/back pad length
Still need to address the alignment issue in L1 since now the total size of a stick is no longer 16B aligned.
Checklist
https://github.com/tenstorrent/tt-metal/actions/runs/12281633434