#0: Remove incorrect assertion on cb page sizes being a multiple of 4… #15752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (should have been 16) and update circular buffer init/usage to support any page size for cbs that aren't used by compute. Compute CBs still require 16B multiple for address/sizes
Ticket
Link to Github Issue
Problem description
We were incorrectly asserting for 4B alignment on main for CB page sizes, when we actually needed 16B. However, we only really need 16B alignment when the CBs are used in compute so we can relax this constraint in some cases.
What's changed
Remove the assertion for 4B alignment for CBs. We will pass and store the original values for address, size, page size when used in a DM kernel, and bit shift these values by 4 when initialized in a compute kernel.
Checklist