Clean up Stable Diffusion tests #15748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmalTT
force-pushed
the
esmal/sd-cleanup
branch
10 times, most recently
from
586c185 to
e5509e7
Compare
mywoodstock
force-pushed
the
esmal/sd-cleanup
branch
from
e5509e7 to
20cf317
Compare
esmalTT
force-pushed
the
esmal/sd-cleanup
branch
3 times, most recently
from
cfe0c01 to
219042b
Compare
Refactor the Stable Diffusion test suite and CI jobs to improve model stability and maintainability. - Move all Stable Diffusion tests into the model directory for better organization. - Remove unnecessary postfixes from test filenames. - Delete dead test code, including tests unrelated to SD modules and code for deprecated SD variants using 224x224 input shapes. - Re-enable previously broken tests in CI. - Update the CODEOWNERS file to reflect moved/deleted directories and files.
esmalTT
force-pushed
the
esmal/sd-cleanup
branch
from
219042b to
31c2105
Compare
esmalTT
requested review from
uaydonat,
mywoodstock,
shwetankTT,
tt-aho,
ayerofieiev-tt,
dmakoviichuk-tt,
cfjchu,
TT-BrianLiu and
a team
as code owners
ayerofieiev-tt
approved these changes
Dec 9, 2024
tt-rkim
approved these changes
Dec 9, 2024
| - model: "wh_b0_unstable" | ||
| cmd: ./tests/scripts/single_card/nightly/run_wh_b0_unstable.sh | ||
| - model: "stable_diffusion" | ||
| cmd: pytest --timeout 900 -n auto tests/nightly/single_card/stable_diffusion |
There was a problem hiding this comment.
We could just move this into the models section then
mywoodstock
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
The Stable Diffusion source code is unorganized and full of dead code. There are several disabled tests contributing to CI instability for this model.
This PR attempts to improve overall model stability, organization, and maintainability.
What's changed
models/demos/wormhole/stable_diffusion/testsinstead of having them scattered around the repository._new_convpostfix from test names.Follow-on work should tackle renaming the files in
models/demos/wormhole/stable_diffusion/tt. It seems like there are several un-tested and un-unused modules in that directory.Checklist