Nkpatel/conv op non tile multiple shard widht #15742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilaykumar Patel <[email protected]> tensor util changes Signed-off-by: Nilaykumar Patel <[email protected]> conv2d changes Signed-off-by: Nilaykumar K Patel <[email protected]> Normal test cases working with updated conv block config. Signed-off-by: Nilaykumar K Patel <[email protected]> kernel changes Signed-off-by: Nilaykumar K Patel <[email protected]> Resolve hang Signed-off-by: Nilaykumar K Patel <[email protected]> Clean up debug statements. Signed-off-by: Nilaykumar K Patel <[email protected]> Clean up debug statements and functions. Signed-off-by: Nilaykumar K Patel <[email protected]> Solve WS test hang. Signed-off-by: Nilaykumar K Patel <[email protected]> Update input offset calculations based on alignment. Signed-off-by: Nilaykumar K Patel <[email protected]> Align input matrix M for 1x1 conv according to new changes. Signed-off-by: Nilaykumar K Patel <[email protected]> Fix after rebase Signed-off-by: Nilaykumar K Patel <[email protected]> Resolve Comments. Signed-off-by: Nilaykumar K Patel <[email protected]> Remove Debug statements and commented code. Signed-off-by: Nilaykumar K Patel <[email protected]> Changes with rebase. Signed-off-by: Nilaykumar K Patel <[email protected]> Undo some changes after rebase-clenup Signed-off-by: Nilaykumar K Patel <[email protected]> Make pipeline work. Clean up needed. Signed-off-by: Nilaykumar K Patel <[email protected]> Update input offset calculations based on alignment. Resolves maxpool and model pipeline failures. Signed-off-by: Nilaykumar K Patel <[email protected]> Enable variable to support non-tile multiple width. Signed-off-by: Nilaykumar K Patel <[email protected]> Divide tiles among cores instead of total height Signed-off-by: Nilaykumar K Patel <[email protected]> Modify Condition Signed-off-by: Nilaykumar K Patel <[email protected]> Change after latest rebase. Signed-off-by: Nilaykumar K Patel <[email protected]> Modify test cases to accomodate small number of cores. Signed-off-by: Nilaykumar Patel <[email protected]> Resolve Yolo failure. Signed-off-by: Nilaykumar Patel <[email protected]> Add support for mulit-device tensor for weight and bias tensors. Signed-off-by: Nilaykumar K Patel <[email protected]> Add comment for prepare weight and bias matrix and modify condition. Signed-off-by: Nilaykumar Patel <[email protected]> Remove debug statements. Signed-off-by: Nilaykumar Patel <[email protected]> Address review comments Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar K Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Signed-off-by: Nilaykumar Patel <[email protected]>
Merge branch 'main' into nkpatel/conv_op_non_tile_multiple_shard_widht
nkpatel-tt
requested review from
mywoodstock,
sankarmanoj-tt,
shwetankTT,
pavlejosipovic,
cfjchu,
ayerofieiev-tt and
dmakoviichuk-tt
as code owners
|
I’m merging this, because it was already approved, and I see the clang-tidy fix. Thanks |
Thanks bryan 👍 |
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Same PR as
#11435
Problem description
With tile multiple shard width, all cores might not be utilised which can degrade performance.
What's changed
Add non-tile multiple shard width support.
Checklist