Formating conv2d output #15741
Merged
Formating conv2d output #15741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwetankTT
requested review from
mywoodstock,
sankarmanoj-tt,
esmalTT,
uaydonat,
tt-aho,
kpaigwar,
xanderchin,
jdesousa-TT,
sjameelTT,
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na and
bbradelTT
as code owners
tt-aho
approved these changes
Dec 6, 2024
esmalTT
requested changes
Dec 6, 2024
There was a problem hiding this comment.
I am seeing failures in Mamba on the nightly pipeline that don't appear on main: https://github.com/tenstorrent/tt-metal/actions/runs/12180236565/job/33990661239#step:9:964
Can you rebase with latest and try again?
sjameelTT
approved these changes
Dec 6, 2024
kpaigwar
approved these changes
Dec 6, 2024
shwetankTT
force-pushed
the
shwetankTT/conv_op_fix
branch
from
0af184d to
009aecf
Compare
|
@esmalTT Hey Evan Can you please unblock me so that I can merge the PR over the weekend. I am running all the pipelines again. Hopefully they pass. |
esmalTT
approved these changes
Dec 6, 2024
shwetankTT
force-pushed
the
shwetankTT/conv_op_fix
branch
from
9b2af82 to
378f29d
Compare
mywoodstock
approved these changes
Dec 6, 2024
shwetankTT
force-pushed
the
shwetankTT/conv_op_fix
branch
from
378f29d to
ebc381a
Compare
ayerofieiev-tt
approved these changes
Dec 7, 2024
uaydonat
approved these changes
Dec 9, 2024
shwetankTT
force-pushed
the
shwetankTT/conv_op_fix
branch
2 times, most recently
from
4651c2a to
55fb873
Compare
bbradelTT
approved these changes
Dec 9, 2024
Co-authored-by: Lewis Panos <[email protected]>
shwetankTT
force-pushed
the
shwetankTT/conv_op_fix
branch
from
55fb873 to
faf91b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#14179
Problem description
Parameterized conv2d output from the Python side:
Users can select the desired output. By default, the function returns the convolution output (conv_output). However, users have the option to receive additional outputs, including the output dimensions, weights, and biases, depending on their needs.
cc: @LPanosTT
(Single-card) Demo tests
(Single-card) Device perf regressions
(Single-card) Model perf tests
Nightly fast dispatch tests
Checklist