Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14063: Fix test by replace wrong default arguments in kernel code #15700

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

amahmudTT
Copy link
Contributor

@amahmudTT amahmudTT commented Dec 4, 2024

Ticket

Link to Github Issue

Problem description

The test failed with PCC errors due to multiple errors, described in the issue. This PR fixes the last one making them fail.

What's changed

The tests were failing because the kernel did not provide arguments to function calls which had wrong default arguments.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@amahmudTT
Copy link
Contributor Author

@amahmudTT amahmudTT merged commit 0f73762 into main Dec 4, 2024
173 checks passed
@amahmudTT amahmudTT deleted the amahmud/embedding_decode branch December 4, 2024 14:56
Copy link

@nvelickovicTT nvelickovicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants