Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_num_nocs() to Hal #15679

Merged
merged 1 commit into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tt_metal/impl/debug/watcher_device_reader.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,8 @@ void WatcherDeviceReader::DumpCore(CoreDescriptor& logical_core, bool is_active_
DumpL1Status(core, &mbox_data->launch[launch_msg_read_ptr]);
}
if (!tt::llrt::OptionsG.watcher_noc_sanitize_disabled()) {
for (uint32_t noc = 0; noc < NUM_NOCS; noc++) {
const auto NUM_NOCS_ = tt::tt_metal::hal.get_num_nocs();
for (uint32_t noc = 0; noc < NUM_NOCS_; noc++) {
DumpNocSanitizeStatus(core, core_str, mbox_data, noc);
}
}
Expand Down
3 changes: 1 addition & 2 deletions tt_metal/impl/debug/watcher_server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
#include "dev_msgs.h"
#include "llrt/llrt.hpp"
#include "llrt/rtoptions.hpp"
#include "noc/noc_overlay_parameters.h"
#include "noc/noc_parameters.h"
#include "debug/ring_buffer.h"
#include "watcher_device_reader.hpp"

Expand Down Expand Up @@ -220,6 +218,7 @@ void watcher_init(Device* device) {
}

// Initialize debug sanity L1/NOC addresses to sentinel "all ok"
const auto NUM_NOCS = tt::tt_metal::hal.get_num_nocs();
for (int i = 0; i < NUM_NOCS; i++) {
data->sanitize_noc[i].noc_addr = watcher::DEBUG_SANITIZE_NOC_SENTINEL_OK_64;
data->sanitize_noc[i].l1_addr = watcher::DEBUG_SANITIZE_NOC_SENTINEL_OK_32;
Expand Down
2 changes: 2 additions & 0 deletions tt_metal/llrt/blackhole/bh_hal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,8 @@ void Hal::initialize_bh() {
this->noc_multicast_encoding_func_ = [](uint32_t x_start, uint32_t y_start, uint32_t x_end, uint32_t y_end) {
return NOC_MULTICAST_ENCODING(x_start, y_start, x_end, y_end);
};

num_nocs_ = NUM_NOCS;
}

} // namespace tt_metal
Expand Down
2 changes: 2 additions & 0 deletions tt_metal/llrt/grayskull/gs_hal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,8 @@ void Hal::initialize_gs() {
this->noc_multicast_encoding_func_ = [](uint32_t x_start, uint32_t y_start, uint32_t x_end, uint32_t y_end) {
return NOC_MULTICAST_ENCODING(x_start, y_start, x_end, y_end);
};

num_nocs_ = NUM_NOCS;
}

} // namespace tt_metal
Expand Down
3 changes: 3 additions & 0 deletions tt_metal/llrt/hal.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ class Hal {
std::vector<DeviceAddr> dram_bases_;
std::vector<uint32_t> dram_sizes_;
std::vector<uint32_t> mem_alignments_;
uint32_t num_nocs_;

void initialize_gs();
void initialize_wh();
Expand All @@ -163,6 +164,8 @@ class Hal {

tt::ARCH get_arch() const { return arch_; }

uint32_t get_num_nocs() const { return num_nocs_; }

template <typename IndexType, typename SizeType, typename CoordType>
auto noc_coordinate(IndexType noc_index, SizeType noc_size, CoordType coord) const
-> decltype(noc_size - 1 - coord) {
Expand Down
2 changes: 2 additions & 0 deletions tt_metal/llrt/wormhole/wh_hal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ void Hal::initialize_wh() {
this->noc_multicast_encoding_func_ = [](uint32_t x_start, uint32_t y_start, uint32_t x_end, uint32_t y_end) {
return NOC_MULTICAST_ENCODING(x_start, y_start, x_end, y_end);
};

num_nocs_ = NUM_NOCS;
}

} // namespace tt_metal
Expand Down
Loading