Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new HAL APIs #15645

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Add new HAL APIs #15645

merged 3 commits into from
Dec 3, 2024

Conversation

blozano-tt
Copy link
Contributor

@blozano-tt blozano-tt commented Dec 3, 2024 •
edited
Loading

Ticket

Closes #14649

Problem description

device.cpp uses ARCH_NAME specific include path noc/noc_parameters.h for NOC_XY_ENCODING

What's changed

Move the API behind the Hal.

Checklist

@blozano-tt blozano-tt added this to the ARCH_NAME Removal milestone Dec 3, 2024
@blozano-tt blozano-tt changed the title Add new HAL API noc_xy_encoding Add new HAL APIs Dec 3, 2024
github-actions[bot]
github-actions bot reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

tt_metal/llrt/hal.hpp Outdated Show resolved Hide resolved
tt_metal/llrt/hal.hpp Outdated Show resolved Hide resolved
tt_metal/llrt/hal.hpp Outdated Show resolved Hide resolved
tt_metal/llrt/hal.hpp Outdated Show resolved Hide resolved
@blozano-tt blozano-tt merged commit db65af5 into main Dec 3, 2024
149 checks passed
@blozano-tt blozano-tt deleted the blozano-noc-xy-encoding branch December 3, 2024 21:04
@blozano-tt blozano-tt restored the blozano-noc-xy-encoding branch December 3, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@pgkeller pgkeller pgkeller approved these changes

@abhullar-tt abhullar-tt Awaiting requested review from abhullar-tt abhullar-tt is a code owner

@aliuTT aliuTT Awaiting requested review from aliuTT aliuTT is a code owner

@tt-aho tt-aho Awaiting requested review from tt-aho tt-aho is a code owner

@tt-dma tt-dma Awaiting requested review from tt-dma tt-dma is a code owner

@tt-asaigal tt-asaigal Awaiting requested review from tt-asaigal tt-asaigal is a code owner

@ubcheema ubcheema Awaiting requested review from ubcheema ubcheema is a code owner

@davorchap davorchap Awaiting requested review from davorchap davorchap is a code owner

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

Assignees
No one assigned
Labels
arch_name cleanup
Projects
None yet
Milestone
ARCH_NAME Removal
Development

Successfully merging this pull request may close these issues.

device.cpp uses ARCH_NAME specific include paths for noc_parameters.h dev_msgs.h dev_mem_map.h
2 participants
@blozano-tt @pgkeller