Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TT-Train] Added LR Schedulers and updated serialization #15625

Merged
merged 15 commits into from
Dec 12, 2024

Conversation

dmakoviichuk-tt
Copy link
Contributor

@dmakoviichuk-tt dmakoviichuk-tt commented Dec 3, 2024

Problem description

Added LR Schedulers, similar to the pytorch's:

  • Linear Scheduler
  • StepScheduler
  • LambdaScheduler
  • SequentialScheduler

What's changed

Checklist

@dmakoviichuk-tt dmakoviichuk-tt changed the title [WIP][TT-Train] Added LR Schedulers and updated serialization [TT-Train] Added LR Schedulers and updated serialization Dec 9, 2024
Copy link
Contributor

@rfurko-tt rfurko-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tt-train/sources/ttml/serialization/serializable.hpp Outdated Show resolved Hide resolved
tt-train/sources/ttml/schedulers/step_scheduler.cpp Outdated Show resolved Hide resolved
@@ -8,8 +8,13 @@
#include <fstream>
#include <iostream>
#include <sstream>
#include <third_party/taskflow/taskflow/utility/serializer.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaked include?

@dmakoviichuk-tt dmakoviichuk-tt merged commit 9a2f119 into main Dec 12, 2024
9 checks passed
@dmakoviichuk-tt dmakoviichuk-tt deleted the DM/schedulers branch December 12, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants