Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eth chan mapping to generated file #15462

Closed
wants to merge 1 commit into from
Closed

Conversation

aliuTT
Copy link
Contributor

@aliuTT aliuTT commented Nov 26, 2024

Ticket

Link to Github Issue

Problem description

Fabric router will need a mapping of ethernet channels to noc_xy_encoding.

What's changed

Added a generated chan to noc_xy_encoding for ethernet cores.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@aliuTT
Copy link
Contributor Author

aliuTT commented Nov 26, 2024

@pgkeller Any concerns with adding a uint16_t eth_chan_to_noc_xy[NUM_NOCS][NUM_ETH_CHANS] to the generated_bank_to_noc_coord_mapping.h? I thought about adding a separate header file, but this seemed easier. It would make sense to rename the mapping file to maybe generated_noc_xy_mapping.h?

Aside, I think we should switch (((2 << NOC_ADDR_NODE_ID_BITS) | 8) << NOC_COORD_REG_OFFSET), to just NOC_XY_ENDCODING(2, 8) for all the generated maps.

@aliuTT aliuTT force-pushed the aliu/add-eth-chan-mapping branch from a6715b4 to 6ebab10 Compare November 26, 2024 22:13
@aliuTT
Copy link
Contributor Author

aliuTT commented Dec 2, 2024

Closing, as there will be new infra to load the generated noc_xy_encoding maps.

@aliuTT aliuTT closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant