Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring UMD into tt-metal repo as an external package using CPM #15354

Closed
wants to merge 3 commits into from

Conversation

blozano-tt
Copy link
Contributor

@blozano-tt blozano-tt commented Nov 22, 2024

Inspired by

@joelsmithTT

Designed to make the following people happy

@broskoTT @afuller-TT

Problem description

Submodules are annoying
Submodules lead to people reaching into things they shouldn't touch
UMD internals need not be exposed in this repo.

What's changed

Use package manager CPM to fetch and build UMD

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@blozano-tt
Copy link
Contributor Author

This PR is waiting on tenstorrent/tt-umd#322

From there this PR needs to be updated to grab UMD from a tag.

Then it needs to be tested.

Base automatically changed from afuller/umd-api to main November 27, 2024 22:41
@blozano-tt blozano-tt closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants