Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N150 llama3 demo CI tests to properly save perf information to superset #15220

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mtairum
Copy link
Contributor

@mtairum mtairum commented Nov 19, 2024

Final change to these CI tests after another back and forth:

Before we were running Llama3 on both N150 and N300 as intended. However the N150 functional pipeline does not upload the perf data to superset, nor does it run on the perf VMs.

This PR changes that.

Instead of running Llama on N150 pipeline, we run them twice on the N300 perf:

  • First time we run them with FAKE_DEVICE=N150 which forces a single-chip execution and saves the N150 perf to superset.
  • Second time it runs normally, on a 2-chip N300 and saves the perf to superset.

To make sure this is the last change we are running the CI test and will make sure all the data is uploaded before committing this.

@mtairum mtairum marked this pull request as ready for review November 19, 2024 17:29
@mtairum mtairum requested a review from tt-rkim as a code owner November 19, 2024 17:29
@mtairum mtairum marked this pull request as draft November 19, 2024 17:30
@mtairum mtairum changed the title Fix N150 llama3 demo CI tests to properly save perf information to dashboard Fix N150 llama3 demo CI tests to properly save perf information to superset Nov 19, 2024
@mtairum mtairum marked this pull request as ready for review November 19, 2024 17:45
@mtairum mtairum merged commit 0926e7d into main Nov 20, 2024
13 of 15 checks passed
@mtairum mtairum deleted the mtairum/llama_N150_perf branch November 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants