-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Tech report section 4.4 #15166
LLM Tech report section 4.4 #15166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review in.
As always, please check my commit diff and see I didn't introduce any mistakes.
tech_reports/LLMs/llms.md
Outdated
activation, | ||
weights, | ||
compute_kernel_config=compute_kernel_config, | ||
core_grid=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this core grid supposed to be None?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the core grid is specified by the program config. I'll remove this line since it's confusing.
e27bc5c
to
0977082
Compare
No description provided.