Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM Tech report section 4.4 #15166

Merged
merged 4 commits into from
Dec 25, 2024
Merged

LLM Tech report section 4.4 #15166

merged 4 commits into from
Dec 25, 2024

Conversation

cglagovichTT
Copy link
Contributor

No description provided.

Copy link
Contributor

@mtairum mtairum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review in.

As always, please check my commit diff and see I didn't introduce any mistakes.

activation,
weights,
compute_kernel_config=compute_kernel_config,
core_grid=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this core grid supposed to be None?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the core grid is specified by the program config. I'll remove this line since it's confusing.

tech_reports/LLMs/llms.md Outdated Show resolved Hide resolved
tech_reports/LLMs/llms.md Show resolved Hide resolved
@uaydonat uaydonat self-requested a review December 19, 2024 02:24
@cglagovichTT cglagovichTT changed the title Section 4.4 first draft LLM Tech report section 4.4 Dec 25, 2024
@cglagovichTT cglagovichTT marked this pull request as ready for review December 25, 2024 03:58
@cglagovichTT cglagovichTT force-pushed the cglagovich/tr_op_config branch from e27bc5c to 0977082 Compare December 25, 2024 03:59
@cglagovichTT cglagovichTT merged commit 9f4eb98 into main Dec 25, 2024
9 checks passed
@cglagovichTT cglagovichTT deleted the cglagovich/tr_op_config branch December 25, 2024 04:02
arikTT pushed a commit that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants