Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14406: Add CCL Perf tests to pipeline #14836

Merged
merged 6 commits into from
Nov 12, 2024
Merged

#14406: Add CCL Perf tests to pipeline #14836

merged 6 commits into from
Nov 12, 2024

Conversation

Aswinmcw
Copy link
Contributor

@Aswinmcw Aswinmcw commented Nov 7, 2024

Ticket

#14406

Problem description

Need CCL Perf to be triggered in pipeline

What's changed

Adds CCL Perf tests to T3K perf pipeline

T3K Model Perf - https://github.com/tenstorrent/tt-metal/actions/runs/11718145347/job/32639080900
Perf Artifact - https://github.com/tenstorrent/tt-metal/actions/runs/11718145347/job/32639080900#step:13:33

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Copy link
Contributor

@SeanNijjar SeanNijjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@Aswinmcw Aswinmcw marked this pull request as ready for review November 7, 2024 15:54
t3000-model-perf-tests:
needs: build-artifact
needs: [build-artifact, build-artifact-profiler]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use only the build-artifact-profiler here?
I don't think we need build-artifact anymore if we want to use profiler tools here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch that, i realized i misread the impl.

Is it possible to introduce an if statement to determine the correct preciding step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have introduced an if statement in the impl file to choose which build to use for that job

Copy link
Contributor

@jvegaTT jvegaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Aswinmcw Aswinmcw force-pushed the Aswinmcw/ccl_perf_ci branch 9 times, most recently from 3385e4d to 200e5d8 Compare November 8, 2024 12:07
@Aswinmcw Aswinmcw force-pushed the Aswinmcw/ccl_perf_ci branch from 200e5d8 to 97cae03 Compare November 12, 2024 04:56
@Aswinmcw Aswinmcw merged commit 9387e7b into main Nov 12, 2024
139 of 146 checks passed
@Aswinmcw Aswinmcw deleted the Aswinmcw/ccl_perf_ci branch November 12, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants