Sdpa pcc improvement #13997
Merged
Sdpa pcc improvement #13997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caixunshiren
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
cfjchu and
TT-BrianLiu
as code owners
caixunshiren
force-pushed
the
sdpa-pcc-improvement
branch
from
22f0c90 to
1d78e56
Compare
TT-BrianLiu
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#13364
#13866
Problem description
Greatly improved pcc of sdpa decode for large sequence length. PCC improved from 0.73 to 0.995+ for 128K sequence length.
What's changed
Checklist