Conv2D with Input & Output in DRAM #13229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mywoodstock
requested review from
sankarmanoj-tt,
ntarafdar,
sjameelTT,
yan-zaretskiy,
jaykru-tt,
shwetankTT,
pavlejosipovic and
bbradelTT
as code owners
mywoodstock
force-pushed
the
smanoj/conv_dram
branch
from
0ba058d to
058eb39
Compare
bbradelTT
requested changes
Sep 30, 2024
| conv_config_l1.output_height_in_l1 = 0; | ||
| conv_config_l1.reshard_if_not_optimal = true; | ||
| ttnn::Tensor sliced_output_tensor; | ||
| std::tie(sliced_output_tensor, std::ignore, std::ignore, weight_tensor_on_device, bias_tensor_on_device) = conv2d( |
There was a problem hiding this comment.
- This function is already too long. You should not add this much new code into it. Please refactor and have new code in a new function.
- Do not make this function recursive. Please have multiple levels instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revival of #12630
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist