#6721: Fix log nan issue #12839
Closed
#6721: Fix log nan issue #12839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruthreshx
requested review from
rtawfik01,
rdjogoTT,
umadevimcw and
eyonland
ruthreshx
force-pushed
the
ruthresh/log_nan_fix
branch
from
27581f8 to
0c5b916
Compare
ruthreshx
force-pushed
the
ruthresh/log_nan_fix
branch
from
0c5b916 to
b7725ba
Compare
ruthreshx
force-pushed
the
ruthresh/log_nan_fix
branch
from
b7725ba to
792f99d
Compare
rtawfik01
reviewed
Sep 23, 2024
| result = std::numeric_limits<float>::quiet_NaN(); | ||
| } | ||
| v_endif; | ||
|
|
There was a problem hiding this comment.
@ruthreshx Can you run the performance pipeline as well and make sure the extra conditional cycles have not had large effects on performance?
There was a problem hiding this comment.
Hi @rtawfik01 ,
May I know what all the workflows that needs to be run for performance check?
There was a problem hiding this comment.
This one for example: https://github.com/tenstorrent/tt-metal/actions/workflows/perf-device-models.yaml
ruthreshx
force-pushed
the
ruthresh/log_nan_fix
branch
from
792f99d to
124a0ee
Compare
ruthreshx
force-pushed
the
ruthresh/log_nan_fix
branch
from
124a0ee to
fd10654
Compare
|
Closing PR as issue has been assigned to LLK Team, #12776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
What's changed
Fix log nan issue
Checklist