Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#10505: migrate prod #10577

Merged
merged 1 commit into from
Jul 24, 2024
Merged

#10505: migrate prod #10577

merged 1 commit into from
Jul 24, 2024

Conversation

KalaivaniMCW
Copy link
Contributor

@KalaivaniMCW KalaivaniMCW commented Jul 23, 2024 •
edited
Loading

Ticket

Link to Github Issue #10505

Problem description

Migrate prod op (ckernel + composite)

What's changed

moved prod from ttnn/experimental to ttnn/eltwise
implement composite prod op

Checklist

@KalaivaniMCW KalaivaniMCW requested a review from umadevimcw July 23, 2024 11:43
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/migrate_prod branch from de5eee5 to 2334cdf Compare July 24, 2024 03:41
@KalaivaniMCW KalaivaniMCW marked this pull request as ready for review July 24, 2024 03:45
eyonland
eyonland approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming you will fix the unnecessary struct being declared as described in the comments.

@KalaivaniMCW
Copy link
Contributor Author

@eyonland @ayerofieiev-tt can I keep the implementation fn as an inline fn in prod.hpp and remove the prod.cpp file ?

@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/migrate_prod branch from fd9a784 to da509a8 Compare July 24, 2024 23:06
@KalaivaniMCW KalaivaniMCW force-pushed the kalaivani/migrate_prod branch from da509a8 to f8d3f97 Compare July 24, 2024 23:57
@KalaivaniMCW KalaivaniMCW merged commit bf9bee9 into main Jul 24, 2024
5 checks passed
@KalaivaniMCW KalaivaniMCW deleted the kalaivani/migrate_prod branch July 24, 2024 23:59
@KalaivaniMCW KalaivaniMCW mentioned this pull request Jul 26, 2024
Closed
ttmchiou pushed a commit that referenced this pull request Jul 30, 2024
@KalaivaniMCW @ttmchiou
#10505: migrate prod (#10577)
eb11d35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayerofieiev-tt ayerofieiev-tt ayerofieiev-tt approved these changes

@eyonland eyonland eyonland approved these changes

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@arakhmati arakhmati Awaiting requested review from arakhmati

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@sangwon-chae sangwon-chae Awaiting requested review from sangwon-chae

@tt-rkim tt-rkim Awaiting requested review from tt-rkim

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@VirdhatchaniKN VirdhatchaniKN Awaiting requested review from VirdhatchaniKN

@Aswinmcw Aswinmcw Awaiting requested review from Aswinmcw

@ruthreshx ruthreshx Awaiting requested review from ruthreshx

@bharane-ab bharane-ab Awaiting requested review from bharane-ab

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KalaivaniMCW @eyonland @ayerofieiev-tt