Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9628: Remove std::function for BW Binary ops #10502

Merged
merged 4 commits into from
Jul 20, 2024
Merged

#9628: Remove std::function for BW Binary ops #10502

merged 4 commits into from
Jul 20, 2024

Conversation

VirdhatchaniKN
Copy link
Contributor

@VirdhatchaniKN VirdhatchaniKN commented Jul 20, 2024 •
edited
Loading

  • Remove std::function for subalpha_bw
  • Update addalpha_bw test file
    • to check for default
    • update golden function
  • Remove
    • get_function_type2
    • get_function_type2_wo_qid

https://github.com/tenstorrent/tt-metal/actions/runs/10020084845 - passed

@VirdhatchaniKN VirdhatchaniKN marked this pull request as ready for review July 20, 2024 12:11
eyonland
eyonland approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@eyonland eyonland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to keep things moving. It seems a lot of our code uses "type1" or "type2". Can we do better in the name?

@VirdhatchaniKN
Copy link
Contributor Author

I'm approving to keep things moving. It seems a lot of our code uses "type1" or "type2". Can we do better in the name?

Yea. I’ll change the name before I merge it to main. Thanks @eyonland

@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/binary_remove branch from 490e37b to c02782d Compare July 20, 2024 17:09
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/binary_remove branch from a0182cc to cae1e15 Compare July 20, 2024 18:13
@VirdhatchaniKN VirdhatchaniKN force-pushed the virdhatchani/binary_remove branch from cae1e15 to 7224325 Compare July 20, 2024 18:46
@VirdhatchaniKN
Copy link
Contributor Author

https://github.com/tenstorrent/tt-metal/actions/runs/10022173689 - passed

@VirdhatchaniKN VirdhatchaniKN merged commit f52ec95 into main Jul 20, 2024
5 checks passed
@VirdhatchaniKN VirdhatchaniKN deleted the virdhatchani/binary_remove branch July 20, 2024 19:11
@VirdhatchaniKN VirdhatchaniKN mentioned this pull request Jul 23, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyonland eyonland eyonland approved these changes

@arakhmati arakhmati Awaiting requested review from arakhmati

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@umadevimcw umadevimcw Awaiting requested review from umadevimcw

@KalaivaniMCW KalaivaniMCW Awaiting requested review from KalaivaniMCW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirdhatchaniKN @eyonland