-
Notifications
You must be signed in to change notification settings - Fork 86
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove firmware dependency on generated_bank_to_noc_coord_mapping.h (#…
…15819) ### Ticket #12844 ### Problem description Firmware build is dependent on runtime values. ### What's changed This PR is same as this one - #15070. Only difference is the 'uninit' changes has been removed. The original PR changes were reverted since the CI had ND hangs on N300. Removing 'uninit' has fixed the hang. Tested with multiple CI runs. https://github.com/tenstorrent/tt-metal/actions/runs/12222728886 https://github.com/tenstorrent/tt-metal/actions/runs/12206639040 https://github.com/tenstorrent/tt-metal/actions/runs/12227870153 https://github.com/tenstorrent/tt-metal/actions/runs/12237979786 Firmware now declares a global array for dram_bank_to_noc_xy, l1_bank_to_noc_xy, bank_to_dram_offset, bank_to_l1_offset. During build, values are written to L1 memory. Firmware during initialization would copy these values from L1 to the above global arrays. Moved l1_to_local_mem_copy to substitutes.cpp. Removed 'inline' keyword as the function is used in multiple places and let LTO decide the inlining ### Checklist - [x] Post commit CI passes - https://github.com/tenstorrent/tt-metal/actions/runs/12227870153 - [x] Blackhole Post commit (if applicable) - https://github.com/tenstorrent/tt-metal/actions/runs/12227923651 - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [ ] **(For models and ops writers)** Full [new models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml) tests passes - [ ] New/Existing tests provide coverage for changes
- Loading branch information
1 parent
cac4dcb
commit c1a246e
Showing
28 changed files
with
239 additions
and
197 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.