#6737: Fix erfc

tenstorrent · Apr 12, 2024 · b024557 · b024557
1 parent a57b5d5
commit b024557
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/tt_metal/hw/ckernels/grayskull/metal/llk_api/llk_sfpu/ckernel_sfpu_erf_erfc.h b/tt_metal/hw/ckernels/grayskull/metal/llk_api/llk_sfpu/ckernel_sfpu_erf_erfc.h
@@ -55,7 +55,7 @@ inline void calculate_erfc() {
 // SFPU microcode:
     for (int d = 0; d < ITERATIONS; d++) {
         vFloat x = dst_reg[0];
-        v_if(x < 0.0f) { x = 1.0 + (calculate_erf_body<APPROXIMATION_MODE>(x)); }
+        v_if(x < 0.0f) { x = -x; x = 1.0 + (calculate_erf_body<APPROXIMATION_MODE>(x)); }
         v_else { x = 1.0 - (calculate_erf_body<APPROXIMATION_MODE>(x)); }
         v_endif;
         dst_reg[0] = x;

diff --git a/tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_sfpu/ckernel_sfpu_erf_erfc.h b/tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_sfpu/ckernel_sfpu_erf_erfc.h
@@ -53,7 +53,7 @@ inline void calculate_erfc() {
 // SFPU microcode:
     for (int d = 0; d < 8; d++) {
         vFloat x = dst_reg[0];
-        v_if(x < 0.0f) { x = 1.0 + (calculate_erf_body<APPROXIMATION_MODE>(x)); }
+        v_if(x < 0.0f) { x = -x; x = 1.0 + (calculate_erf_body<APPROXIMATION_MODE>(x)); }
         v_else { x = 1.0 - (calculate_erf_body<APPROXIMATION_MODE>(x)); }
         v_endif;
         dst_reg[0] = x;