Skip to content

Commit

Permalink
Run Blackhole on 22.04 (#15970)
Browse files Browse the repository at this point in the history
### Ticket
#14393

### Problem description
Move BH pipeline to 22.04

### What's changed
* Plumb the correct version of Python to the wheel builder
* Install the repo to be able to run the unit tests -- not really sure
why it fails in 22.04 but was okay with 20.04.

### Checklist
- [x] Post commit CI passes
https://github.com/tenstorrent/tt-metal/actions/runs/12300743997
- [x] Blackhole Post commit (if applicable)
https://github.com/tenstorrent/tt-metal/actions/runs/12289973402
  • Loading branch information
afuller-TT authored Dec 12, 2024
1 parent 52cc437 commit 3bf0fd6
Show file tree
Hide file tree
Showing 5 changed files with 28 additions and 8 deletions.
6 changes: 6 additions & 0 deletions .github/actions/prepare-metal-run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ inputs:
description: "Whether to load with profiler"
required: false
default: 'false'
python-version:
description: 'Which version of Python to use to run the tests.'
required: false
default: '3.8'

runs:
using: "composite"
Expand All @@ -25,6 +29,8 @@ runs:
shell: bash
run: tar -xvf ttm_${{ inputs.arch }}.tar
- uses: ./.github/actions/install-python-deps
with:
python-version: ${{ inputs.python-version }}
- name: Collect Workflow Telemetry
if: ${{ !cancelled() }}
uses: catchpoint/workflow-telemetry-action@v2
12 changes: 12 additions & 0 deletions .github/workflows/_build-wheels-impl.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,17 @@ jobs:
os: ${{ inputs.os }}
- name: Clean up dirty files
run: git clean -f -d
- name: Set Python Version
id: python-version
run: |
if [[ "${{ inputs.os }}" == "ubuntu-20.04" ]]; then
echo "python-version=3.8" >> $GITHUB_ENV
elif [[ "${{ inputs.os }}" == "ubuntu-22.04" ]]; then
echo "python-version=3.10" >> $GITHUB_ENV
else
echo "Unsupported OS version: ${{ inputs.os }}"
exit 1
fi
- uses: actions/[email protected]
with:
cache: 'pip'
Expand All @@ -47,6 +58,7 @@ jobs:
if: ${{ inputs.from-precompiled }}
with:
arch: ${{ inputs.arch }}
python-version: ${{ env.python-version }}
- name: Set precompiled dir for precompile builds
if: ${{ inputs.from-precompiled }}
# TT_FROM_PRECOMPILED_DIR env variable allows us to not re-run the full C++ build and instead
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/blackhole-post-commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,14 @@ jobs:
uses: ./.github/workflows/build-artifact.yaml
secrets: inherit
with:
os: "ubuntu-20.04-amd64"
os: "ubuntu-22.04-amd64"
arch: '["blackhole"]'
build-docker: false
build-wheels:
needs: build-artifact
uses: ./.github/workflows/_build-wheels-impl.yaml
with:
os: "ubuntu-20.04"
os: "ubuntu-22.04"
arch: "blackhole"
from-precompiled: true
# build-artifact-profiler:
Expand All @@ -58,15 +58,15 @@ jobs:
arch: blackhole
runner-label: BH
timeout: 30
os: "ubuntu-20.04"
os: "ubuntu-22.04"
fd-unit-tests:
needs: build-wheels
uses: ./.github/workflows/fast-dispatch-build-and-unit-tests.yaml
secrets: inherit
with:
arch: blackhole
runner-label: BH
os: "ubuntu-20.04"
os: "ubuntu-22.04"
# FD C++ Unit Tests
cpp-unit-tests:
needs: build-artifact
Expand All @@ -76,7 +76,7 @@ jobs:
arch: blackhole
runner-label: BH
timeout: 60
os: "ubuntu-20.04"
os: "ubuntu-22.04"

# profiler-regression:
# needs: build-artifact-profiler
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/build-and-unit-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ jobs:
-e TT_METAL_SLOW_DISPATCH_MODE=1
-e LD_LIBRARY_PATH=${{ github.workspace }}/build/lib
run_args: |
python3 -m pip install -r $(pwd)/tt_metal/python_env/requirements-dev.txt
pip install --force-reinstall pip==21.2.4
pip install -r tt_metal/python_env/requirements-dev.txt
pip install -e .
./tests/scripts/run_tests.sh --tt-arch ${{ inputs.arch }} --pipeline-type post_commit --dispatch-mode slow
- uses: ./.github/actions/slack-report
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/cpp-post-commit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,9 @@ jobs:
-e ARCH_NAME=${{ inputs.arch }}
-e LD_LIBRARY_PATH=${{ github.workspace }}/build/lib
run_args: |
python3 -m pip install -r $(pwd)/tt_metal/python_env/requirements-dev.txt
python3 -m pip install -e .
pip install --force-reinstall pip==21.2.4
pip install -r tt_metal/python_env/requirements-dev.txt
pip install -e .
${{ matrix.test-group.cmd }}
- uses: ./.github/actions/slack-report
if: ${{ failure() }}
Expand Down

0 comments on commit 3bf0fd6

Please sign in to comment.