Skip to content

Commit

Permalink
#15713 Bad Eltwise Binary ZEROACC (#16094)
Browse files Browse the repository at this point in the history
### Ticket
#15713

### Problem description
Instruction for clearing the DEST (ZEROACC) doesn't work the same on BH
and WH_B0 for 32-bit mode. On WH_B0, two ZEROACC instructions are needed
to clear half of a face each, because ZEROACC clears8 x 16 datums (half
of a face), if we use CLR_16 mode and use 32-bit DEST mode. On BH,
however, this is not the case - CLR_16 mode will always clear 16 x 16
datums (a whole face), size of which in bytes is determined by fp32 bit
of the instruction.

### What's changed
Corrected ZEROACC call for clearing the DEST when we reuse it in eltwise
binary ops.

### Checklist
- [x] Post commit CI passes - [before pipeline
broke](https://github.com/tenstorrent/tt-metal/actions/runs/12354236372
), after pipeline broke
[#22539](https://github.com/tenstorrent/tt-metal/actions/runs/12371210472),
[#22474](https://github.com/tenstorrent/tt-metal/actions/runs/12357394873)
- [x] Blackhole Post commit (if applicable) - [before pipeline
broke](https://github.com/tenstorrent/tt-metal/actions/runs/12355477287),
after pipeline broke
[#2408](https://github.com/tenstorrent/tt-metal/actions/runs/12371201293)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [x] New/Existing tests provide coverage for changes
  • Loading branch information
ncvetkovicTT authored Dec 18, 2024
1 parent b4af6c8 commit 3be17c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tt_metal/third_party/tt_llk_blackhole

0 comments on commit 3be17c1

Please sign in to comment.